Duplicate Tabs Closer에 대한 리뷰
Duplicate Tabs Closer 제작자: Peuj
Firefox 사용자 13943793 님의 리뷰
5점 만점에 4점
Firefox 사용자 13943793 님, 7년 전Super extension overall, but there is a bug in the settings handling for filters.
If "Ignore search part..." is set, then "Ignore hash part ..." isn't doing anything. Similarly of "Ignore path part ..." is set then the two other settings are useless.
This is due to "else if" being used in areMatchingURL function from urlUtils.js (line 24, 28). Switching this to independent ifs allows to respect all settings (and support urls having both hash and search signs.
If possible please bring a fix for this one (I can provide a pull request if the code is on some git repo).
Thanks in advance.
If "Ignore search part..." is set, then "Ignore hash part ..." isn't doing anything. Similarly of "Ignore path part ..." is set then the two other settings are useless.
This is due to "else if" being used in areMatchingURL function from urlUtils.js (line 24, 28). Switching this to independent ifs allows to respect all settings (and support urls having both hash and search signs.
If possible please bring a fix for this one (I can provide a pull request if the code is on some git repo).
Thanks in advance.